update ember-cli et al #1395
Merged
update ember-cli et al #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
commented
Jul 13, 2017
| })).to.eventually.be.rejectedWith( | ||
| 'Authenticators cannot extend from themself. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".' | ||
| ); | ||
| xit('throws when the authenticator is specified as its own base class', function() { |
There was a problem hiding this comment.
These tests currently fail due to ember-cli/ember-cli#7019
Turbo87
reviewed
Jul 14, 2017
blueprints/authenticator/index.js
Outdated
| @@ -38,7 +38,7 @@ module.exports = { | |||
| body: EOL + ' restore(data) {' + EOL + ' },' + EOL + EOL + ' authenticate(/*args*/) {' + EOL + ' },' + EOL + EOL + ' invalidate(data) {' + EOL + ' }' | |||
| }; | |||
| } else if (name === baseClass) { | |||
| throw new SilentError('Authenticators cannot extend from themself. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".'); | |||
| throw new SilentError('Authenticators cannot extend from themselves. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".'); | |||
There was a problem hiding this comment.
seems unrelated to the PR purpose of updating depenendencies?
| SilentError, | ||
| 'Authenticators cannot extend from themselves. Remove the --base-class option or specify one of "oauth2", "torii" or "devise".' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
the changed exception also seems unrelated to the PR purpose
There was a problem hiding this comment.
Yeah, was trying to fix the tests until I figured out they were breaking because of ember-cli
package.json
Outdated
| "cors": "^2.8.4", | ||
| "ember-cli": "~2.14.0", | ||
| "ember-cli-addon-tests": "^0.7.0", | ||
| "ember-bootstrap": "^1.0.0-beta.2", |
package.json
Outdated
| "chai": "^4.1.0", | ||
| "cors": "^2.8.4", | ||
| "ember-cli": "~2.14.0", | ||
| "ember-cli-addon-tests": "^0.7.0", |
There was a problem hiding this comment.
this looks like a new dependency, not an updated one? 🤔
|
@Turbo87: good to approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆙